Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.23] Automated cherry pick of #110950: filter out terminated containers in cadvisor_stats_provider #112964

Merged
merged 1 commit into from Oct 18, 2022
Merged

[1.23] Automated cherry pick of #110950: filter out terminated containers in cadvisor_stats_provider #112964

merged 1 commit into from Oct 18, 2022

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Oct 10, 2022 •
edited

Cherry pick of #110950 on release-1.23.

#112984 - Kubelet overrides (non-empty) container metrics from CRI with empty cAdvisor metrics
#110950: filter out terminated containers in cadvisor_stats_provider

Issue - #103368

For details on the cherry pick process, see the cherry pick requests page.

Kubelet no longer reports terminated container metrics from cAdvisor

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 10, 2022
@bobbypage bobbypage changed the title Automated cherry pick of #110950: filter out terminated containers in cadvisor_stats_provider [1.23] Automated cherry pick of #110950: filter out terminated containers in cadvisor_stats_provider Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 11, 2022
@bobbypage bobbypage mentioned this pull request Oct 11, 2022
Closed
@bobbypage
Copy link
Member Author

/cc @haircommander @konstantin-s-bogom @dashpole

@k8s-ci-robot
Copy link
Contributor

@bobbypage: GitHub didn't allow me to request PR reviews from the following users: konstantin-s-bogom.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @haircommander @konstantin-s-bogom @dashpole

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Contributor

/lgtm
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@konstantin-s-bogom konstantin-s-bogom mentioned this pull request Oct 11, 2022
Closed
dashpole
dashpole approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@bobbypage
Copy link
Member Author

cc @kubernetes/release-managers

for cherrypick approvals

@xmudrii
Copy link
Member

xmudrii commented Oct 12, 2022

/hold
Patch releases are currently being cut, therefore cherry-pick deadline is still in effect.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2022
@SergeyKanzhelev
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 13, 2022
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Done in SIG Node PR Triage Oct 13, 2022
@xmudrii
Copy link
Member

xmudrii commented Oct 17, 2022

/kind bug

xmudrii
xmudrii approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel
the cherry pick deadline is over

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 17, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, dashpole, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Oct 18, 2022

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0ac8938 into kubernetes:release-1.23 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@xmudrii xmudrii xmudrii approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@sjenning sjenning Awaiting requested review from sjenning

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@haircommander haircommander

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bobbypage @k8s-ci-robot @haircommander @xmudrii @SergeyKanzhelev @dashpole @yangjunmyfm192085