Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #115315: kubelet/client: collapse transport wiring onto standard #115580

Merged
merged 1 commit into from Feb 10, 2023
Merged

Automated cherry pick of #115315: kubelet/client: collapse transport wiring onto standard #115580

merged 1 commit into from Feb 10, 2023

Conversation

enj
Copy link
Member

@enj enj commented Feb 7, 2023 •
edited

Cherry pick of #115315 on release-1.24.

#115315: kubelet/client: collapse transport wiring onto standard

For details on the cherry pick process, see the cherry pick requests page.

The Kubernetes API server now correctly detects and closes existing TLS connections when its client certificate file for kubelet authentication has been rotated.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver labels Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2023
@enj enj mentioned this pull request Feb 7, 2023
Closed
@cici37
Copy link
Contributor

cici37 commented Feb 7, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 7, 2023
@jeremyrickard
Copy link
Contributor

/retest

@enj
kubelet/client: collapse transport wiring onto standard approach
1455d33 
Signed-off-by: Monis Khan <mok@microsoft.com>
@enj enj force-pushed the automated-cherry-pick-of-#115315-upstream-release-1.24 branch from 91a4a5c to 1455d33 Compare February 8, 2023 16:39
@bart0sh
Copy link
Contributor

bart0sh commented Feb 9, 2023

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 9, 2023
@bart0sh bart0sh added this to Needs Reviewer in SIG Node PR Triage Feb 9, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Feb 10, 2023

/lgtm
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6c18666c26b123b983cde388b7f523c7953b662a

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 10, 2023
@liggitt
Copy link
Member

liggitt commented Feb 10, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@jeremyrickard jeremyrickard added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 10, 2023
@jeremyrickard
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 337d682 into kubernetes:release-1.24 Feb 10, 2023
SIG Node CI/Test Board automation moved this from Triage to Done Feb 10, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Feb 10, 2023
@enj enj deleted the automated-cherry-pick-of-#115315-upstream-release-1.24 branch June 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@liggitt liggitt

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@enj @cici37 @jeremyrickard @bart0sh @k8s-ci-robot @liggitt