Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #112913: fix GetAllocatableCPUs in cpumanager #113422

Merged
merged 2 commits into from Nov 1, 2022
Merged

Automated cherry pick of #112913: fix GetAllocatableCPUs in cpumanager #113422

merged 2 commits into from Nov 1, 2022

Conversation

Garrybest
Copy link
Member

@Garrybest Garrybest commented Oct 28, 2022 •
edited

Cherry pick of #112913 on release-1.23.

#112913: fix GetAllocatableCPUs in cpumanager

For details on the cherry pick process, see the cherry pick requests page.

kubelet: fix GetAllocatableCPUs method in cpumanager

@Garrybest
fix GetAllocatableCPUs in cpumanager
67309f5 
Signed-off-by: Garrybest <garrybest@foxmail.com>
@Garrybest
add GetAllocatableCPUs test in cpumanager
f1e3eab 
Signed-off-by: Garrybest <garrybest@foxmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 28, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 28, 2022
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Garrybest. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 28, 2022
swatisehgal
swatisehgal reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2022
@swatisehgal
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2022
@swatisehgal
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 28, 2022
@swatisehgal
Copy link
Contributor

swatisehgal commented Oct 28, 2022 •
edited

Please update the release note (NONE in this case) either through a prow command or by updating the PR description.

@klueska
Copy link
Contributor

klueska commented Oct 28, 2022

/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 28, 2022
@Garrybest
Copy link
Member Author

/retest

@Garrybest
Copy link
Member Author

/rest

@Garrybest
Copy link
Member Author

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team November 1, 2022 02:06
cpanato
cpanato approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Garrybest, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 1, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 1, 2022
@xmudrii
Copy link
Member

xmudrii commented Nov 1, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2022
@klueska
Copy link
Contributor

klueska commented Nov 1, 2022

@xmudrii Why the hold?

@xmudrii
Copy link
Member

xmudrii commented Nov 1, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2022
@xmudrii
Copy link
Member

xmudrii commented Nov 1, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit b84042e into kubernetes:release-1.23 Nov 1, 2022
@Garrybest Garrybest deleted the automated-cherry-pick-of-#112913-origin-release-1.23 branch November 2, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal left review comments

@cpanato cpanato cpanato approved these changes

@klueska klueska Awaiting requested review from klueska

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@cpanato cpanato

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Garrybest @k8s-ci-robot @swatisehgal @klueska @xmudrii @cpanato