Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #116395: One lock among PodNominator and SchedulingQueue #116439

Merged
merged 1 commit into from Mar 10, 2023
Merged

Automated cherry pick of #116395: One lock among PodNominator and SchedulingQueue #116439

merged 1 commit into from Mar 10, 2023

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Mar 9, 2023 •
edited

Cherry pick of #116395 on release-1.25.

#116395: One lock among PodNominator and SchedulingQueue

For details on the cherry pick process, see the cherry pick requests page.

Fix data race in kube-scheduler when preemption races with a Pod update.

@alculquicondor
One lock among PodNominator and SchedulingQueue
42c5d12 
Change-Id: I17fe5da40250e42c04124c25b530ce6c8dea4154
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 9, 2023
@alculquicondor
Copy link
Member Author

/kind bug
/priority critical-urgent
/triage accepted

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. approved Indicates a PR has been approved by an approver from all required OWNERS files. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2023
@alculquicondor alculquicondor mentioned this pull request Mar 9, 2023
Merged
@Huang-Wei
Copy link
Member

/lgtm

cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ddc5494a28da7edfd0c5bece6ebf1dd49abffe06

@alculquicondor
Copy link
Member Author

/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team March 9, 2023 21:50
@Verolop
Copy link

Verolop commented Mar 10, 2023

/lgtm

k8s-ci-robot added a commit that referenced this pull request Mar 10, 2023
@k8s-ci-robot
Merge pull request #116440 from alculquicondor/automated-cherry-pick-…
f8d1ec4 
…of-#116439-upstream-release-1.24

Automated cherry pick of #116439: One lock among PodNominator and SchedulingQueue
@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9b46f1c into kubernetes:release-1.25 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendave chendave Awaiting requested review from chendave

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@Huang-Wei Huang-Wei

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alculquicondor @k8s-ci-robot @Huang-Wei @Verolop