Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make STS available replicas optional #113122

Merged
merged 1 commit into from Oct 18, 2022
Merged

Make STS available replicas optional #113122

merged 1 commit into from Oct 18, 2022

Conversation

ashrayjain
Copy link

@ashrayjain ashrayjain commented Oct 17, 2022 •
edited by liggitt

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #109210

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a 1.22 regression in published openapi: make STS available replicas optional again

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Make STS available replicas optional again.

@k8s-ci-robot @ashrayjain
Merge pull request kubernetes#109241 from ravisantoshgudimetla/sts-ar…
b6e86eb 
…-optional

Make STS available replicas optional
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 17, 2022
@k8s-ci-robot
Copy link
Contributor

@ashrayjain: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @ashrayjain!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ashrayjain. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 17, 2022
@ashrayjain ashrayjain changed the title Merge pull request #109241 from ravisantoshgudimetla/sts-ar-optional Make STS available replicas optional Oct 17, 2022
@odinuge
Copy link
Member

odinuge commented Oct 17, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2022
@ashrayjain
Copy link
Author

/retest

@ashrayjain
Copy link
Author

@liggitt this PR is ready for your review! Thanks

@liggitt
Copy link
Member

liggitt commented Oct 18, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2022
@liggitt liggitt added this to API review completed, 1.26 in API Reviews Oct 18, 2022
@liggitt
Copy link
Member

liggitt commented Oct 18, 2022

/kind regression

@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2022
@ashrayjain
Copy link
Author

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team October 18, 2022 16:37
@xmudrii
Copy link
Member

xmudrii commented Oct 18, 2022

@ashrayjain @liggitt Just to confirm, this has been fixed in 1.24 by #109241, so we only need to cherry-pick it to 1.23. Is that correct?

@liggitt
Copy link
Member

liggitt commented Oct 18, 2022

yes

xmudrii
xmudrii approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashrayjain, liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 18, 2022
@ashrayjain
Copy link
Author

/retest

1 similar comment
@ashrayjain
Copy link
Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit e50a1c0 into kubernetes:release-1.23 Oct 18, 2022
@ashrayjain ashrayjain deleted the aj/cherry-pick branch October 19, 2022 04:20
@liggitt liggitt added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework and removed kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FillZpp FillZpp FillZpp left review comments

@xmudrii xmudrii xmudrii approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.26
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ashrayjain @k8s-ci-robot @odinuge @liggitt @xmudrii @FillZpp