Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #115341: apiserver: remove 34s from DELETECOLLECTION rest handler #115481

Merged
merged 1 commit into from Feb 9, 2023
Merged

Automated cherry pick of #115341: apiserver: remove 34s from DELETECOLLECTION rest handler #115481

merged 1 commit into from Feb 9, 2023

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Feb 2, 2023 •
edited by liggitt

Cherry pick of #115341 on release-1.25.

What this PR does / why we need it:

Remove 34s timeout (enforced at rest handler layer) from DELETECOLLECTION since it is naturally a lengthy operation. This will enforce the default 60s timeout on a DELETECOLLECTION request if the user does not specify any timeout in the request URI

Which issue(s) this PR fixes:

Fixes #115090

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix the 1.21 regression that introduced 34s timeout for DELETECOLLECTION calls

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 2, 2023
@tkashem
Copy link
Contributor Author

tkashem commented Feb 2, 2023

/kind bug
/sig api-machinery
/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 2, 2023
@cici37
Copy link
Contributor

cici37 commented Feb 2, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 2, 2023
@wojtek-t
Copy link
Member

wojtek-t commented Feb 2, 2023

/lgtm
/approve
/priority important-soon

@kubernetes/release-managers - for cherrypick approval

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5764688f70f09f4fbc6d3ba598d1cdcdd3a6cc35

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tkashem, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@Verolop
Copy link

Verolop commented Feb 9, 2023

/sig api-machinery

@Verolop Verolop removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 9, 2023
@Verolop
Copy link

Verolop commented Feb 9, 2023

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4c75855 into kubernetes:release-1.25 Feb 9, 2023
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Mar 1, 2023
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@Verolop Verolop

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tkashem @cici37 @wojtek-t @k8s-ci-robot @Verolop @liggitt