Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #112489: etcd: Updated to v3.5.5 #113099

Merged
merged 1 commit into from Oct 22, 2022
Merged

Automated cherry pick of #112489: etcd: Updated to v3.5.5 #113099

merged 1 commit into from Oct 22, 2022

Conversation

mk46
Copy link
Member

@mk46 mk46 commented Oct 17, 2022 •
edited

Cherry pick of #112489 on release-1.24.

#112489: etcd: Updated to v3.5.5

For details on the cherry pick process, see the cherry pick requests page.

etcd: Update to v3.5.5

@dims @mk46
etcd: Updated to v3.5.5
97c8d24 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 17, 2022
@dims
Copy link
Member

dims commented Oct 18, 2022

/kind bug
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 18, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2022
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 18, 2022
@dims
Copy link
Member

dims commented Oct 19, 2022

/approve
/lgtm

@pacoxu
Copy link
Member

pacoxu commented Oct 20, 2022

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team October 20, 2022 06:11
@xmudrii
Copy link
Member

xmudrii commented Oct 20, 2022

As far as I see, the original PR (#112489) targets 1.26, but I don't see a cherry pick for the release-1.25 branch. Can you please confirm if we need to cherry pick this to 1.25 or not?

@pacoxu
Copy link
Member

pacoxu commented Oct 20, 2022 •
edited

As far as I see, the original PR (#112489) targets 1.26, but I don't see a cherry pick for the release-1.25 branch. Can you please confirm if we need to cherry pick this to 1.25 or not?

@xmudrii This is because both 3.5.4 and 3.5.5 etcd are ok versions. v1.25 is now with etcd v3.5.4 which is ok.

looks like some of the stable branches do not have a good version of etcd yet 😞

@xmudrii
Copy link
Member

xmudrii commented Oct 20, 2022

@pacoxu Is it technically possible to bump 1.25 to etcd 3.5.5? Even considering 3.5.4 is okay, I would avoid the "doughnut effect", i.e. that we have 1.23 and 1.24 on etcd 3.5.5, 1.25 on etcd 3.5.4, and then again 1.26 on etcd 3.5.5.

@pacoxu
Copy link
Member

pacoxu commented Oct 20, 2022

@pacoxu Is it technically possible to bump 1.25 to etcd 3.5.5? Even considering 3.5.4 is okay, I would avoid the "doughnut effect", i.e. that we have 1.23 and 1.24 on etcd 3.5.5, 1.25 on etcd 3.5.4, and then again 1.26 on etcd 3.5.5.

Of course. I opened #113197 for v1.25.

@xmudrii
Copy link
Member

xmudrii commented Oct 20, 2022

@pacoxu Thanks a lot! Once cherry pick for 1.25 is lgtm-ed and approved, I'll go ahead and cherry-pick-approve all three PRs.

xmudrii
xmudrii approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mk46, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 21, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 21, 2022
@xmudrii
Copy link
Member

xmudrii commented Oct 21, 2022

/retest

1 similar comment
@mk46
Copy link
Member Author

mk46 commented Oct 22, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 94ab67c into kubernetes:release-1.24 Oct 22, 2022
@xmudrii xmudrii mentioned this pull request Nov 24, 2022
Merged
@linki linki mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@ibabou ibabou Awaiting requested review from ibabou

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@dims dims

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mk46 @dims @fedebongio @pacoxu @xmudrii @k8s-ci-robot