Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make STS available replicas optional #109241

Merged
merged 2 commits into from Apr 2, 2022
Merged

Make STS available replicas optional #109241

merged 2 commits into from Apr 2, 2022

Conversation

ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Apr 1, 2022 •
edited by liggitt

What type of PR is this?

/kind regression

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #109210

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes a 1.22 regression in published openapi: make STS available replicas optional again

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Make STS available replicas optional again,

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 1, 2022
@ravisantoshgudimetla ravisantoshgudimetla changed the title Sts ar optional Make STS available replicas optional Apr 1, 2022
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 1, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Member

liggitt commented Apr 1, 2022

/lgtm
/approve
/retest
/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@liggitt
Copy link
Member

liggitt commented Apr 1, 2022

/retest

1 similar comment
@liggitt
Copy link
Member

liggitt commented Apr 2, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 3024ddc into kubernetes:master Apr 2, 2022
@github-actions github-actions bot mentioned this pull request Apr 5, 2022
Open
@cici37
Copy link
Contributor

cici37 commented Apr 5, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 5, 2022
@liggitt liggitt mentioned this pull request May 15, 2022
Closed
LarsMichelsen pushed a commit to Checkmk/checkmk that referenced this pull request Jul 14, 2022
@SoloJacobs
transform: update typing for Kubernetes 1.24
26a1327 
available_replicas being non-optional is considered a bug, which has
been fixed in 1.24, see
kubernetes/kubernetes#109241

CMK-10232

Change-Id: Id27543e90e6ea6e2cfffc010f98e7b5371c1dabf
jplitza pushed a commit to PLUTEX/checkmk that referenced this pull request Aug 23, 2022
@SoloJacobs @jplitza
transform: update typing for Kubernetes 1.24
000963b 
available_replicas being non-optional is considered a bug, which has
been fixed in 1.24, see
kubernetes/kubernetes#109241

CMK-10232

Change-Id: Id27543e90e6ea6e2cfffc010f98e7b5371c1dabf
ashrayjain pushed a commit to ashrayjain/kubernetes that referenced this pull request Oct 17, 2022
@k8s-ci-robot @ashrayjain
Merge pull request kubernetes#109241 from ravisantoshgudimetla/sts-ar…
b6e86eb 
…-optional

Make STS available replicas optional
@xmudrii xmudrii mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

StatefulSetStatus attribute availableReplicas set to required by mistake?
5 participants
@ravisantoshgudimetla @k8s-triage-robot @liggitt @k8s-ci-robot @cici37